Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test on R-devel #2528

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Fix failing test on R-devel #2528

merged 7 commits into from
Mar 21, 2024

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Mar 20, 2024

Coming from changes to the parser in R-devel

Closes #2527

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (106dfb4) to head (66f19be).

❗ Current head 66f19be differs from pull request most recent head 563b66e. Consider uploading reports for the commit 563b66e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         125      125           
  Lines        5715     5715           
=======================================
  Hits         5611     5611           
  Misses        104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IndrajeetPatil IndrajeetPatil changed the title Reproduce r-devel problem on GitHub Fix failing test on R-devel Mar 20, 2024
cran-comments.md Outdated Show resolved Hide resolved
MichaelChirico
MichaelChirico previously approved these changes Mar 21, 2024
@MichaelChirico MichaelChirico merged commit 3f59265 into main Mar 21, 2024
20 checks passed
@MichaelChirico MichaelChirico deleted the fix-devel-failing-test branch March 21, 2024 06:39
MichaelChirico added a commit that referenced this pull request Mar 21, 2024
* to kick off CI/CD

* fix failing test

* Test robust across R versions

* with_content_to_parse doesn't get parent env variables?

* revert changes to cran comments

* better test

* useBytes=TRUE

---------

Co-authored-by: Michael Chirico <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRAN failures on R-devel
4 participants